[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge/raminit: Improve readability

Patrick Rudolph (Code Review) gerrit at coreboot.org
Fri Sep 22 16:18:03 CEST 2017


Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/21638


Change subject: nb/intel/sandybridge/raminit: Improve readability
......................................................................

nb/intel/sandybridge/raminit: Improve readability

Improve readability of SPD probing.

Change-Id: I722102b7981781b88cdc4877f698294eb719ff32
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
M src/northbridge/intel/sandybridge/raminit.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/21638/1

diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c
index 2854a2b..bdba748 100644
--- a/src/northbridge/intel/sandybridge/raminit.c
+++ b/src/northbridge/intel/sandybridge/raminit.c
@@ -209,6 +209,9 @@
 		/* count dimms on channel */
 		for (slot = 0; slot < NUM_SLOTS; slot++) {
 			spd_slot = 2 * channel + slot;
+			printk(BIOS_DEBUG,
+			       "SPD probe channel%d, slot%d\n", channel, slot);
+
 			spd_decode_ddr3(&dimm->dimm[channel][slot], spd[spd_slot]);
 			if (dimm->dimm[channel][slot].dram_type == SPD_MEMORY_TYPE_SDRAM_DDR3)
 				dimms_on_channel++;
@@ -216,6 +219,9 @@
 
 		for (slot = 0; slot < NUM_SLOTS; slot++) {
 			spd_slot = 2 * channel + slot;
+			printk(BIOS_DEBUG,
+			       "SPD probe channel%d, slot%d\n", channel, slot);
+
 			/* search for XMP profile */
 			spd_xmp_decode_ddr3(&dimm->dimm[channel][slot],
 					spd[spd_slot],

-- 
To view, visit https://review.coreboot.org/21638
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I722102b7981781b88cdc4877f698294eb719ff32
Gerrit-Change-Number: 21638
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170922/a55749ba/attachment.html>


More information about the coreboot-gerrit mailing list