[coreboot-gerrit] Change in coreboot[master]: src/lib/ubsan: Indent macros to improve readability

Marc Jones (Code Review) gerrit at coreboot.org
Thu Sep 21 21:46:44 CEST 2017


Marc Jones has submitted this change and it was merged. ( https://review.coreboot.org/21600 )

Change subject: src/lib/ubsan: Indent macros to improve readability
......................................................................

src/lib/ubsan: Indent macros to improve readability

Change-Id: Ide4e58e584a1a2bbc1b861e2c4dd943a1aeb35ab
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Reviewed-on: https://review.coreboot.org/21600
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Ryan Salsamendi <rsalsamendi at hotmail.com>
Reviewed-by: Marc Jones <marc at marcjonesconsulting.com>
---
M src/lib/ubsan.c
1 file changed, 9 insertions(+), 11 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Ryan Salsamendi: Looks good to me, but someone else must approve
  Marc Jones: Looks good to me, approved



diff --git a/src/lib/ubsan.c b/src/lib/ubsan.c
index 1cd0612..ead0e18 100644
--- a/src/lib/ubsan.c
+++ b/src/lib/ubsan.c
@@ -61,22 +61,20 @@
 }
 
 #define ABORT_VARIANT(name, params, call) \
-__attribute__((noreturn)) \
-void __ubsan_handle_##name##_abort params; \
-__attribute__((noreturn)) \
-void __ubsan_handle_##name##_abort params { \
-	__ubsan_handle_##name call; \
-	__builtin_unreachable(); \
-}
+	__attribute__((noreturn)) void __ubsan_handle_##name##_abort params; \
+	__attribute__((noreturn)) void __ubsan_handle_##name##_abort params { \
+		__ubsan_handle_##name call; \
+		__builtin_unreachable(); \
+	}
 
 #define ABORT_VARIANT_VP(name) \
-ABORT_VARIANT(name, (void *a), (a))
+	ABORT_VARIANT(name, (void *a), (a))
 #define ABORT_VARIANT_VP_VP(name) \
-ABORT_VARIANT(name, (void *a, void *b), (a, b))
+	ABORT_VARIANT(name, (void *a, void *b), (a, b))
 #define ABORT_VARIANT_VP_IP(name) \
-ABORT_VARIANT(name, (void *a, intptr_t b), (a, b))
+	ABORT_VARIANT(name, (void *a, intptr_t b), (a, b))
 #define ABORT_VARIANT_VP_VP_VP(name) \
-ABORT_VARIANT(name, (void *a, void *b, void *c), (a, b, c))
+	ABORT_VARIANT(name, (void *a, void *b, void *c), (a, b, c))
 
 struct ubsan_type_mismatch_data {
 	struct ubsan_source_location location;

-- 
To view, visit https://review.coreboot.org/21600
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide4e58e584a1a2bbc1b861e2c4dd943a1aeb35ab
Gerrit-Change-Number: 21600
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Ryan Salsamendi <rsalsamendi at hotmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170921/01f6510a/attachment.html>


More information about the coreboot-gerrit mailing list