[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add FSP GOP support.

[Abhay Kumar (Code Review)]

Abhay Kumar has posted comments on this change. ( https://review.coreboot.org/21628 )

Change subject: soc/intel/cannonlake: Add FSP GOP support.
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/21628/1/src/soc/intel/cannonlake/chip.c
File src/soc/intel/cannonlake/chip.c:

https://review.coreboot.org/#/c/21628/1/src/soc/intel/cannonlake/chip.c@172
PS1, Line 172: 	if (vbt)
> that will be working? Seems like different scope.
Yeah this will free memory and since VBT is global we can access. This is same as reef.



-- 
To view, visit https://review.coreboot.org/21628
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf836d683ae00cd034c853bc9ce965d4de5f7413
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 2
Gerrit-Owner: Abhay Kumar <abhay.kumar at intel.com>
Gerrit-Reviewer: Abhay Kumar <abhay.kumar at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Surendranath R Gurivireddy <surendranath.r.gurivireddy at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 21 Sep 2017 18:55:47 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170921/3fbac69e/attachment.html>