[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Remove old soc_get_rtc_failed function
Martin Roth (Code Review)
gerrit at coreboot.org
Thu Sep 21 03:01:48 CEST 2017
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/21616
Change subject: soc/intel/cannonlake: Remove old soc_get_rtc_failed function
......................................................................
soc/intel/cannonlake: Remove old soc_get_rtc_failed function
In coreboot commit bcd0bdabed (soc/intel/cannonlake: add rtc failure
checking), the function soc_get_rtc_failed was supposed to be moved,
but the old function was not removed, causing a build error.
BUG=b:63054105
Change-Id: I31c1966af413df3f5a5492a5dd891a6eb26a1fc4
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/soc/intel/cannonlake/pmc.c
1 file changed, 0 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/21616/1
diff --git a/src/soc/intel/cannonlake/pmc.c b/src/soc/intel/cannonlake/pmc.c
index a91e5ea..e9972a6 100644
--- a/src/soc/intel/cannonlake/pmc.c
+++ b/src/soc/intel/cannonlake/pmc.c
@@ -87,22 +87,6 @@
}
}
-int soc_get_rtc_failed(void)
-{
- uint8_t reg8;
- int rtc_failed;
- uint8_t *pmcbase = pmc_mmio_regs();
-
- reg8 = read8(pmcbase + GEN_PMCON_B);
- rtc_failed = reg8 & RTC_BATTERY_DEAD;
- if (rtc_failed) {
- reg8 &= ~RTC_BATTERY_DEAD;
- write8(pmcbase + GEN_PMCON_B, reg8);
- printk(BIOS_DEBUG, "rtc_failed = 0x%x\n", rtc_failed);
- }
- return rtc_failed;
-}
-
static void config_deep_sX(uint32_t offset, uint32_t mask, int sx, int enable)
{
uint32_t reg;
--
To view, visit https://review.coreboot.org/21616
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I31c1966af413df3f5a5492a5dd891a6eb26a1fc4
Gerrit-Change-Number: 21616
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170921/e09d6b5c/attachment.html>
More information about the coreboot-gerrit
mailing list