[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Clean up include files in northbridge.h

Marshall Dawson (Code Review) gerrit at coreboot.org
Thu Sep 21 02:38:53 CEST 2017


Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/21615


Change subject: amd/stoneyridge: Clean up include files in northbridge.h
......................................................................

amd/stoneyridge: Clean up include files in northbridge.h

Add an extra include file to northbridge.c for completeness.  cpu/msr.h
is already included in cpu/amd/mtrr.h which allows the file to build
properly.

Remove include files that are no longer required for the file.

Change-Id: I3e5ab39fd0640d2983fc5b7b202fb65d42c5ce3d
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/soc/amd/stoneyridge/northbridge.c
1 file changed, 1 insertion(+), 13 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/21615/1

diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c
index ae2cdbb..07ea10f 100644
--- a/src/soc/amd/stoneyridge/northbridge.c
+++ b/src/soc/amd/stoneyridge/northbridge.c
@@ -23,11 +23,10 @@
 #include <cpu/amd/amdfam15.h>
 #include <cpu/amd/mtrr.h>
 #include <cpu/cpu.h>
+#include <cpu/x86/msr.h>
 #include <device/device.h>
 #include <device/pci.h>
 #include <device/pci_ids.h>
-#include <device/hypertransport.h>
-#include <lib.h>
 #include <agesawrapper.h>
 #include <agesawrapper_call.h>
 #include <soc/northbridge.h>
@@ -35,17 +34,6 @@
 #include <stdint.h>
 #include <stdlib.h>
 #include <string.h>
-
-/*
- * AMD vendorcode files. Place at the end so coreboot defaults and maintained
- * and not set by vendorcode
- */
-#include <AGESA.h>
-#include <cpuRegisters.h>
-#include <FieldAccessors.h>
-#include <Options.h>
-#include <Porting.h>
-#include <Topology.h>
 
 typedef struct dram_base_mask {
 	u32 base; /* [47:27] at [28:8] */

-- 
To view, visit https://review.coreboot.org/21615
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e5ab39fd0640d2983fc5b7b202fb65d42c5ce3d
Gerrit-Change-Number: 21615
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170921/1db1e3bc/attachment.html>


More information about the coreboot-gerrit mailing list