[coreboot-gerrit] Change in coreboot[master]: mainboard: use SeaBIOS config only when it's the payload of choice

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/21611 )

Change subject: mainboard: use SeaBIOS config only when it's the payload of choice
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/21611/1/src/mainboard/adi/rcc-dff/Kconfig
File src/mainboard/adi/rcc-dff/Kconfig:

https://review.coreboot.org/#/c/21611/1/src/mainboard/adi/rcc-dff/Kconfig@72
PS1, Line 72: if PAYLOAD_SEABIOS
While this works, could we use 'depends on PAYLOAD_SEABIOS' instead?  We generally don't use if/endif for a single config option.



-- 
To view, visit https://review.coreboot.org/21611
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1629aecf33cb62bb1e6856ef5627748a7dc74d8a
Gerrit-Change-Number: 21611
Gerrit-PatchSet: 1
Gerrit-Owner: Lubomir Rintel <lkundrak at v3.sk>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 20 Sep 2017 19:23:42 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170920/8eba4ce7/attachment.html>