[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Update LPC lib

Ravishankar Sarawadi (Code Review) gerrit at coreboot.org
Wed Sep 20 00:23:19 CEST 2017


Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/21605 )

Change subject: soc/intel/common/block: Update LPC lib
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/21605/2/src/soc/intel/common/block/lpc/lpc_lib.c
File src/soc/intel/common/block/lpc/lpc_lib.c:

https://review.coreboot.org/#/c/21605/2/src/soc/intel/common/block/lpc/lpc_lib.c@253
PS2, Line 253: 	soc_get_gen_io_dec_config(dev, gen_io_dec);
> A weak will be needed here? Or any dependency for this function?
Will fix.



-- 
To view, visit https://review.coreboot.org/21605
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9359765f7293210044b411db49163df0418070a
Gerrit-Change-Number: 21605
Gerrit-PatchSet: 2
Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 19 Sep 2017 22:23:19 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170919/45779c99/attachment.html>


More information about the coreboot-gerrit mailing list