[coreboot-gerrit] Change in coreboot[master]: ec/lenovo/h8: Add support for bluetooth on wifi

Martin Roth (Code Review) gerrit at coreboot.org
Tue Sep 19 16:14:53 CEST 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/21578 )

Change subject: ec/lenovo/h8: Add support for bluetooth on wifi
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/21578/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/21578/1//COMMIT_MSG@11
PS1, Line 11: failes
fails


https://review.coreboot.org/#/c/21578/1/src/ec/lenovo/h8/Kconfig
File src/ec/lenovo/h8/Kconfig:

https://review.coreboot.org/#/c/21578/1/src/ec/lenovo/h8/Kconfig@28
PS1, Line 28: Don't care for BDC detection as wifi card does have Bluetooth
Could you reword this? Maybe
Force bluetooth to be enabled on wifi cards.


https://review.coreboot.org/#/c/21578/1/src/ec/lenovo/h8/Kconfig@28
PS1, Line 28: "
Remove trailing quote.



-- 
To view, visit https://review.coreboot.org/21578
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23f14c937252a296dc543db49ec9e093e7e24604
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 19 Sep 2017 14:14:53 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170919/1ab1b662/attachment.html>


More information about the coreboot-gerrit mailing list