[coreboot-gerrit] Change in coreboot[master]: ec/quanta/it8518: add missing HID to SIO device

Matt DeVillier (Code Review) gerrit at coreboot.org
Sun Sep 17 21:31:27 CEST 2017


Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/21580


Change subject: ec/quanta/it8518: add missing HID to SIO device
......................................................................

ec/quanta/it8518: add missing HID to SIO device

The ACPI spec requires devices with children to have an HID,
and Windows enforces this strictly. Without the SIO device
having an HID, Windows will not detect the attached PS2 keyboard
and trackpad.  Therefore, add the proper HID.

TEST: boot Windows on google/stout, observe PS2 keyboard and
trackpad detected and functional.

Change-Id: I61d7341c15483f8e1fe0e485a25591ceb92eaae1
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/ec/quanta/it8518/acpi/superio.asl
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/21580/1

diff --git a/src/ec/quanta/it8518/acpi/superio.asl b/src/ec/quanta/it8518/acpi/superio.asl
index 1bd0a39..e912e04 100644
--- a/src/ec/quanta/it8518/acpi/superio.asl
+++ b/src/ec/quanta/it8518/acpi/superio.asl
@@ -17,6 +17,7 @@
 
 Device (SIO)
 {
+	Name (_HID, EisaId("PNP0A05"))
 	Name (_UID, 0)
 	Name (_ADR, 0)
 

-- 
To view, visit https://review.coreboot.org/21580
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61d7341c15483f8e1fe0e485a25591ceb92eaae1
Gerrit-Change-Number: 21580
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170917/4eebc439/attachment.html>


More information about the coreboot-gerrit mailing list