[coreboot-gerrit] Change in coreboot[master]: ec/quanta/it8518: correct ACPI battery data fed into ToString()

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/21579


Change subject: ec/quanta/it8518: correct ACPI battery data fed into ToString()
......................................................................

ec/quanta/it8518: correct ACPI battery data fed into ToString()

ToString() requires the input buffer data to be null-terminated,
but the data returned by the EC is not, leading Windows to fail
to report any battery data at all.  Correct this by concatenating
a null terminator (0x00) to the end of the buffer data before
inputting to ToString() where needed

TEST: boot Windows on google/stout, observe battery data
reported correctly.

Change-Id: I974afcd6ff1c617301d0897d6bd1fe14200aa3b9
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/ec/quanta/it8518/acpi/battery.asl
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/21579/1

diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl
index 1f37f13..862e907 100644
--- a/src/ec/quanta/it8518/acpi/battery.asl
+++ b/src/ec/quanta/it8518/acpi/battery.asl
@@ -185,7 +185,7 @@
 		//
 		//  Battery Type - Device Chemistry
 		//
-		Store (ToString (SBCH), Index (PBIF, 11))
+		Store (ToString (Concatenate(SBCH, 0x00)), Index (PBIF, 11))
 
 		//
 		// Information ID 5 -
@@ -196,7 +196,7 @@
 		//
 		// OEM Information - Manufacturer Name
 		//
-		Store (ToString (SBMN), Index (PBIF, 12))
+		Store (ToString (Concatenate(SBMN, 0x00)), Index (PBIF, 12))
 
 		//
 		// Information ID 6 -
@@ -207,7 +207,7 @@
 		//
 		// Model Number - Device Name
 		//
-		Store (ToString (SBDN), Index (PBIF, 9))
+		Store (ToString (Concatenate(SBDN, 0x00)), Index (PBIF, 9))
 
 		Return (PBIF)
 	}

-- 
To view, visit https://review.coreboot.org/21579
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I974afcd6ff1c617301d0897d6bd1fe14200aa3b9
Gerrit-Change-Number: 21579
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170917/e3f05fb9/attachment.html>