[coreboot-gerrit] Change in coreboot[master]: cpu/intel/car/cache_as_ram.inc: Remove unused code

Keith Hui (Code Review) gerrit at coreboot.org
Tue Sep 12 00:53:06 CEST 2017


Keith Hui has uploaded this change for review. ( https://review.coreboot.org/21502


Change subject: cpu/intel/car/cache_as_ram.inc: Remove unused code
......................................................................

cpu/intel/car/cache_as_ram.inc: Remove unused code

Remove CAR testing code currently blocked out by #if. Newer CAR code
don't even do it anymore.

Change-Id: I2d53b4e7a244824c7aa2c0f597ed91e17f6cc668
Signed-off-by: Keith Hui <buurin at gmail.com>
---
M src/cpu/intel/car/cache_as_ram.inc
1 file changed, 0 insertions(+), 44 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/21502/1

diff --git a/src/cpu/intel/car/cache_as_ram.inc b/src/cpu/intel/car/cache_as_ram.inc
index baa10c0..7cf55b3 100644
--- a/src/cpu/intel/car/cache_as_ram.inc
+++ b/src/cpu/intel/car/cache_as_ram.inc
@@ -187,50 +187,6 @@
 	xorl	%eax, %eax
 	rep	stosl
 
-#if 0
-	/* Check the cache as ram. */
-	movl	$CacheBase, %esi
-	movl	$(CacheSize >> 2), %ecx
-.xin1:
-	movl	%esi, %eax
-	movl	%eax, (%esi)
-	decl	%ecx
-	je	.xout1
-	add	$4, %esi
-	jmp	.xin1
-.xout1:
-
-	movl	$CacheBase, %esi
-	// movl	$(CacheSize >> 2), %ecx
-	movl	$4, %ecx
-.xin1x:
-	movl	%esi, %eax
-
-	movl	$0x4000, %edx
-	movb	%ah, %al
-.testx1:
-	outb	%al, $0x80
-	decl	%edx
-	jnz	.testx1
-
-	movl	(%esi), %eax
-	cmpb	0xff, %al
-	je	.xin2	/* Don't show. */
-
-	movl	$0x4000, %edx
-.testx2:
-	outb	%al, $0x80
-	decl	%edx
-	jnz	.testx2
-
-.xin2:
-	decl	%ecx
-	je	.xout1x
-	add	$4, %esi
-	jmp	.xin1x
-.xout1x:
-#endif
-
 	movl	$(CacheBase + CacheSize - 4), %eax
 	movl	%eax, %esp
 lout:

-- 
To view, visit https://review.coreboot.org/21502
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d53b4e7a244824c7aa2c0f597ed91e17f6cc668
Gerrit-Change-Number: 21502
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui <buurin at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170911/f91d5ea5/attachment.html>


More information about the coreboot-gerrit mailing list