[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Simplify memory hole calculation

[Marshall Dawson (Code Review)]

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/21496


Change subject: amd/stoneyridge: Simplify memory hole calculation
......................................................................

amd/stoneyridge: Simplify memory hole calculation

Delete the obselete Kconfig symbols regarding the memory hole.  Integrate
the hole check into domain_set_resources().  The hardware configuration
is done by AGESA, so only discover the setting and adjust the mmio_basek
accordingly.

Change-Id: Id15a88897e29bff28ab7c498dc4d3818834f08b2
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/soc/amd/stoneyridge/Kconfig
M src/soc/amd/stoneyridge/northbridge.c
2 files changed, 5 insertions(+), 55 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/21496/1

diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig
index f8768e7..1e13cc0 100644
--- a/src/soc/amd/stoneyridge/Kconfig
+++ b/src/soc/amd/stoneyridge/Kconfig
@@ -110,14 +110,6 @@
 	  option is useful when PCI peripherals requesting large address
 	  ranges are present.
 
-config HW_MEM_HOLE_SIZEK
-	hex
-	default 0x200000
-
-config HW_MEM_HOLE_SIZE_AUTO_INC
-	bool
-	default n
-
 config MMCONF_BASE_ADDRESS
 	hex
 	default 0xF8000000
diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c
index 2ed3156..f45a885 100644
--- a/src/soc/amd/stoneyridge/northbridge.c
+++ b/src/soc/amd/stoneyridge/northbridge.c
@@ -415,41 +415,13 @@
 	printk(BIOS_DEBUG, "  ader - leaving domain_enable_resources.\n");
 }
 
-#if CONFIG_HW_MEM_HOLE_SIZEK != 0
-struct hw_mem_hole_info {
-	unsigned int hole_startk;
-	int node_id;
-};
-
-static struct hw_mem_hole_info get_hw_mem_hole_info(void)
-{
-	struct hw_mem_hole_info mem_hole;
-	mem_hole.hole_startk = CONFIG_HW_MEM_HOLE_SIZEK;
-	mem_hole.node_id = -1;
-	dram_base_mask_t d;
-	u32 hole;
-	d = get_dram_base_mask();
-	hole = pci_read_config32(dev_find_slot(0, ADDR_DEVFN), 0xf0);
-	if (hole & 2) {
-		/* We found the hole */
-		mem_hole.hole_startk = (hole & (0xff << 24)) >> 10;
-		mem_hole.node_id = 0; /* record the node # with hole */
-	}
-
-	return mem_hole;
-}
-#endif
-
 void domain_set_resources(device_t dev)
 {
 	unsigned long mmio_basek;
 	u32 pci_tolm;
+	u32 hole;
 	int idx;
 	struct bus *link;
-#if CONFIG_HW_MEM_HOLE_SIZEK != 0
-	struct hw_mem_hole_info mem_hole;
-	u32 reset_memhole = 1;
-#endif
 
 	pci_tolm = 0xffffffffUL;
 	for (link = dev->link_list ; link ; link = link->next)
@@ -461,25 +433,11 @@
 
 	/* FIXME improve mtrr.c so we don't use up all of the mtrrs with a 64M
 	 * MMIO hole. If you fix this here, please fix amdk8, too.
-	*/
-	/* Round the mmio hole to 64M */
-	mmio_basek &= ~((64 * 1024) - 1);
-
-#if CONFIG_HW_MEM_HOLE_SIZEK != 0
-	/* if the hw mem hole is already set in raminit stage, here we will
-	 * compare mmio_basek and hole_basek. if mmio_basek is bigger that
-	 * hole_basek and will use hole_basek as mmio_basek and we don't need
-	 * to reset hole.  Otherwise we reset the hole to the mmio_basek
 	 */
-
-	mem_hole = get_hw_mem_hole_info();
-
-	/* Use hole_basek as mmio_basek, and no need to reset hole anymore */
-	if ((mem_hole.node_id !=  -1) && (mmio_basek > mem_hole.hole_startk)) {
-		mmio_basek = mem_hole.hole_startk;
-		reset_memhole = 0;
-	}
-#endif
+	mmio_basek &= ~((64 * 1024) - 1); /* Round the mmio hole to 64M */
+	hole = pci_read_config32(dev_find_slot(0, ADDR_DEVFN), 0xf0);
+	if (hole & 2) /* hole hoisted by AGESA? */
+		mmio_basek = (hole & ((u32)0xff * 16*MiB)) / KiB;
 
 	idx = 0x10;
 	dram_base_mask_t d;

-- 
To view, visit https://review.coreboot.org/21496
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id15a88897e29bff28ab7c498dc4d3818834f08b2
Gerrit-Change-Number: 21496
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170911/6e06855e/attachment.html>