[coreboot-gerrit] Change in coreboot[master]: vboot: Add config to enable EC EFS support

Daisuke Nojiri (Code Review) gerrit at coreboot.org
Mon Sep 11 22:47:38 CEST 2017


Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/21489


Change subject: vboot: Add config to enable EC EFS support
......................................................................

vboot: Add config to enable EC EFS support

This patch makes coreboot set VBSD_EC_EFS flag if CONFIG_VBOOT_EC_EFS
is set. Depthcharge/Vboot uses this flag to determine whether it can
update EC when it's already running a RW copy.

BUG=b:65028930
BRANCH=none
CQ-DEPEND=CL:616346
TEST=Verify soft sync runs successfully on Fizz.

Change-Id: Ic51ddd4819262162a8d8519461c4ace57ee01cb5
Signed-off-by: Daisuke Nojiri <dnojiri at chromium.org>
---
M src/vboot/Kconfig
M src/vboot/vboot_handoff.c
2 files changed, 15 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/21489/1

diff --git a/src/vboot/Kconfig b/src/vboot/Kconfig
index 8c8dffe..14490d6 100644
--- a/src/vboot/Kconfig
+++ b/src/vboot/Kconfig
@@ -167,6 +167,15 @@
 	  Whether the EC (or PD) is slow to update and needs to display a
 	  screen that informs the user the update is happening.
 
+config VBOOT_EC_EFS
+	bool "Run software sync for EFS EC"
+	default n
+	depends on VBOOT_EC_SOFTWARE_SYNC
+	help
+	  CrosEC can support EFS: Early Firmware Selection. If it's enabled,
+	  software sync need to also support it. This switch enables EFS
+	  support for software sync.
+
 config VBOOT_PHYSICAL_DEV_SWITCH
 	bool
 	default n
diff --git a/src/vboot/vboot_handoff.c b/src/vboot/vboot_handoff.c
index 64c8ca6..974fe78 100644
--- a/src/vboot/vboot_handoff.c
+++ b/src/vboot/vboot_handoff.c
@@ -83,12 +83,15 @@
 	/* TODO: Set these in depthcharge */
 	if (!IS_ENABLED(CONFIG_VBOOT_PHYSICAL_DEV_SWITCH))
 		vb_sd->flags |= VBSD_HONOR_VIRT_DEV_SWITCH;
-	if (IS_ENABLED(CONFIG_VBOOT_EC_SOFTWARE_SYNC))
+	if (IS_ENABLED(CONFIG_VBOOT_EC_SOFTWARE_SYNC)) {
 		vb_sd->flags |= VBSD_EC_SOFTWARE_SYNC;
+		if (IS_ENABLED(CONFIG_VBOOT_EC_SLOW_UPDATE))
+			vb_sd->flags |= VBSD_EC_SLOW_UPDATE;
+		if (IS_ENABLED(CONFIG_VBOOT_EC_EFS))
+			vb_sd->flags |= VBSD_EC_EFS;
+	}
 	if (!IS_ENABLED(CONFIG_VBOOT_PHYSICAL_REC_SWITCH))
 		vb_sd->flags |= VBSD_BOOT_REC_SWITCH_VIRTUAL;
-	if (IS_ENABLED(CONFIG_VBOOT_EC_SLOW_UPDATE))
-		vb_sd->flags |= VBSD_EC_SLOW_UPDATE;
 	if (IS_ENABLED(CONFIG_VBOOT_OPROM_MATTERS)) {
 		vb_sd->flags |= VBSD_OPROM_MATTERS;
 		/*

-- 
To view, visit https://review.coreboot.org/21489
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic51ddd4819262162a8d8519461c4ace57ee01cb5
Gerrit-Change-Number: 21489
Gerrit-PatchSet: 1
Gerrit-Owner: Daisuke Nojiri <dnojiri at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170911/909e295a/attachment.html>


More information about the coreboot-gerrit mailing list