[coreboot-gerrit] Change in coreboot[master]: mb/sapphire/pureplatinumh61: Remove S3 resume delay

Nicola Corna (Code Review) gerrit at coreboot.org
Mon Sep 11 16:56:06 CEST 2017


Nicola Corna has uploaded this change for review. ( https://review.coreboot.org/21485


Change subject: mb/sapphire/pureplatinumh61: Remove S3 resume delay
......................................................................

mb/sapphire/pureplatinumh61: Remove S3 resume delay

It seems that recent changes in coreboot have fixed the raminit issues
on this board; the workaround of 10 ms delay after the S3 resume is not
needed anymore and can be removed.

Change-Id: If8fb97ecf3eb797f53270a053201fafd32031678
Signed-off-by: Nicola Corna <nicola at corna.info>
---
M src/mainboard/sapphire/pureplatinumh61/romstage.c
1 file changed, 0 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/21485/1

diff --git a/src/mainboard/sapphire/pureplatinumh61/romstage.c b/src/mainboard/sapphire/pureplatinumh61/romstage.c
index be692f6..b9a0b8c 100644
--- a/src/mainboard/sapphire/pureplatinumh61/romstage.c
+++ b/src/mainboard/sapphire/pureplatinumh61/romstage.c
@@ -70,13 +70,6 @@
 
 void mainboard_early_init(int s3resume)
 {
-	if (s3resume) {
-		/*
-		 * Raminit after S3 resume fails if started too early; a delay
-		 * of 10 ms seems to be sufficient to fix the issue.
-		 */
-		mdelay(10);
-	}
 }
 
 void mainboard_config_superio(void)

-- 
To view, visit https://review.coreboot.org/21485
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8fb97ecf3eb797f53270a053201fafd32031678
Gerrit-Change-Number: 21485
Gerrit-PatchSet: 1
Gerrit-Owner: Nicola Corna <nicola at corna.info>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170911/239c9ef0/attachment.html>


More information about the coreboot-gerrit mailing list