[coreboot-gerrit] Change in coreboot[master]: mb/google/soraka: Update DPTF parameters

Furquan Shaikh (Code Review) gerrit at coreboot.org
Fri Sep 8 18:00:34 CEST 2017


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/21453 )

Change subject: mb/google/soraka: Update DPTF parameters
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/21453/3/src/mainboard/google/poppy/variants/soraka/include/variant/acpi/dptf.asl
File src/mainboard/google/poppy/variants/soraka/include/variant/acpi/dptf.asl:

https://review.coreboot.org/#/c/21453/3/src/mainboard/google/poppy/variants/soraka/include/variant/acpi/dptf.asl@4
PS3, Line 4: 2016
Why did this change from 2017 to 2016?


https://review.coreboot.org/#/c/21453/3/src/mainboard/google/poppy/variants/soraka/include/variant/acpi/dptf.asl@47
PS3, Line 47: 	
one more tab to align it with other comments above?



-- 
To view, visit https://review.coreboot.org/21453
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6af93fa358a037df2088213ee4df5e2cfd047590
Gerrit-Change-Number: 21453
Gerrit-PatchSet: 3
Gerrit-Owner: Wisley Chen <wisley.chen at quantatw.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 08 Sep 2017 16:00:34 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170908/03e7afeb/attachment.html>


More information about the coreboot-gerrit mailing list