[coreboot-gerrit] Change in coreboot[master]: drivers/intel/gma/vbt.c: Add GENERAL DEFINITIONS block to fake vbt

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21448 )

Change subject: drivers/intel/gma/vbt.c: Add GENERAL DEFINITIONS block to fake vbt
......................................................................


Patch Set 1:

> Maybe don't add the general definitions block at all if VGADDC?
 > Other-
 > wise somebody should check if the incomplete general definitions
 > block
 > has any unwanted side effects (e.g. does LVDS still work? DP dual
 > mode?
 > etc.).

good idea. I was thinking that this change be hard to test on all platform using it but restricting to only when needed seems to be a good solution here to avoid potential regressions.


-- 
To view, visit https://review.coreboot.org/21448
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bce00d2e37d77c27cf0022c7dab3444c3699dcf
Gerrit-Change-Number: 21448
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 07 Sep 2017 21:34:32 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170907/d88492aa/attachment.html>