[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Move SCI to IRQ 10

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/21418 )

Change subject: siemens/mc_apl1: Move SCI to IRQ 10
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/21418/1/src/mainboard/siemens/mc_apl1/mainboard.c
File src/mainboard/siemens/mc_apl1/mainboard.c:

https://review.coreboot.org/#/c/21418/1/src/mainboard/siemens/mc_apl1/mainboard.c@117
PS1, Line 117: static void mainboard_enable(device_t dev)
Do we really want to have it in the mainboard_enable() function? Are there any reasons against mainboard_init() or even mainboard_final()? How big is the chance that FSP will re-route the SCI in one of it's callbacks?



-- 
To view, visit https://review.coreboot.org/21418
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b8bfbdd8ab9498197603572b0e533f405a340fe
Gerrit-Change-Number: 21418
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 06 Sep 2017 09:17:11 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170906/8579942e/attachment.html>