[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Set bus master bit for on-board PCI device

Mario Scheithauer (Code Review) gerrit at coreboot.org
Tue Sep 5 15:41:27 CEST 2017


Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/21405


Change subject: siemens/mc_apl1: Set bus master bit for on-board PCI device
......................................................................

siemens/mc_apl1: Set bus master bit for on-board PCI device

There is one on-board PCI device where bus master has to be enabled in
PCI configuration space. As there is no need for a complete PCI driver
for this device just set the bus master bit in mainboard_final().

Change-Id: I45202937eba11da3bea14fef6ebed70599804335
Signed-off-by: Mario Scheithauer <mario.scheithauer at siemens.com>
---
M src/mainboard/siemens/mc_apl1/mainboard.c
1 file changed, 12 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/21405/1

diff --git a/src/mainboard/siemens/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/mainboard.c
index 4c90aff..d8374fc 100644
--- a/src/mainboard/siemens/mc_apl1/mainboard.c
+++ b/src/mainboard/siemens/mc_apl1/mainboard.c
@@ -15,8 +15,9 @@
  */
 
 #include <console/console.h>
-#include <device/pci.h>
 #include <device/device.h>
+#include <device/pci.h>
+#include <device/pci_ids.h>
 #include <hwilib.h>
 #include <i210.h>
 #include <intelblocks/lpc_lib.h>
@@ -115,6 +116,8 @@
 static void mainboard_final(void *chip_info)
 {
 	int status;
+	uint16_t cmd = 0;
+	device_t dev = NULL;
 
 	/**
 	 * Set up the DP2LVDS converter.
@@ -128,6 +131,14 @@
 
 	/* Enable additional I/O decoding range on LPC for COM 3 */
 	lpc_open_pmio_window(0x3e8, 8);
+
+	/* Set Master Enable for on-board PCI device. */
+	dev = dev_find_device(PCI_VENDOR_ID_SIEMENS, 0x403f, 0);
+	if (dev) {
+		cmd = pci_read_config16(dev, PCI_COMMAND);
+		cmd |= PCI_COMMAND_MASTER;
+		pci_write_config16(dev, PCI_COMMAND, cmd);
+	}
 }
 
 struct chip_operations mainboard_ops = {

-- 
To view, visit https://review.coreboot.org/21405
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45202937eba11da3bea14fef6ebed70599804335
Gerrit-Change-Number: 21405
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170905/f9b86c38/attachment-0001.html>


More information about the coreboot-gerrit mailing list