[coreboot-gerrit] Change in coreboot[master]: device: Skip EBDA area reinitialization if CONFIG_EARLY_EBDA_INIT sel...

Subrata Banik (Code Review) gerrit at coreboot.org
Mon Sep 4 15:34:56 CEST 2017


Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/21389


Change subject: device: Skip EBDA area reinitialization if CONFIG_EARLY_EBDA_INIT selected
......................................................................

device: Skip EBDA area reinitialization if CONFIG_EARLY_EBDA_INIT selected

CONFIG_EARLY_EBDA_INIT kconfig will ensure EBDA area getting
initialized during romstage.

This patch ensures that dev_initializa() shouldn't
override already initialized EBDA area, hence just skip
reinitialization part based on kconfig option.

Change-Id: I797933b9a6aea21793b3f19e45dde0ba9d536370
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
M src/device/device.c
1 file changed, 7 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/21389/1

diff --git a/src/device/device.c b/src/device/device.c
index 35f5909..4c6b6f9 100644
--- a/src/device/device.c
+++ b/src/device/device.c
@@ -1179,8 +1179,13 @@
 	printk(BIOS_INFO, "Initializing devices...\n");
 
 #if IS_ENABLED(CONFIG_ARCH_X86)
-	/* Ensure EBDA is prepared before Option ROMs. */
-	setup_default_ebda();
+	/*
+	 * Initialize EBDA area in ramstage if early
+	 * initialization is not done.
+	 */
+	if (!IS_ENABLED(CONFIG_EARLY_EBDA_INIT))
+		/* Ensure EBDA is prepared before Option ROMs. */
+		setup_default_ebda();
 #endif
 
 	/* First call the mainboard init. */

-- 
To view, visit https://review.coreboot.org/21389
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I797933b9a6aea21793b3f19e45dde0ba9d536370
Gerrit-Change-Number: 21389
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170904/d2758ccc/attachment.html>


More information about the coreboot-gerrit mailing list