[coreboot-gerrit] Change in coreboot[master]: rmodtool: Increase limit on number of symbols

Philippe Mathieu-Daudé (Code Review) gerrit at coreboot.org
Mon Sep 4 02:17:55 CEST 2017


Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/21360 )

Change subject: rmodtool: Increase limit on number of symbols
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

add a new variable

https://review.coreboot.org/#/c/21360/1/util/cbfstool/elfheaders.c
File util/cbfstool/elfheaders.c:

https://review.coreboot.org/#/c/21360/1/util/cbfstool/elfheaders.c@a438
PS1, Line 438: 
name this shnum (same type, Elf64_Half)


https://review.coreboot.org/#/c/21360/1/util/cbfstool/elfheaders.c@438
PS1, Line 438: Elf64_Word
use Elf64_Xword for i (new var)



-- 
To view, visit https://review.coreboot.org/21360
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad2f64c452cef2e7bf957f766600891cb5ae798
Gerrit-Change-Number: 21360
Gerrit-PatchSet: 1
Gerrit-Owner: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug at amsat.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 04 Sep 2017 00:17:55 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170904/b5837f58/attachment.html>


More information about the coreboot-gerrit mailing list