[coreboot-gerrit] Change in coreboot[master]: fsp1_0/fsp_util: Rename find_fsp to find_fsp_dummy
Damien Zammit (Code Review)
gerrit at coreboot.org
Sun Sep 3 03:00:55 CEST 2017
Damien Zammit has posted comments on this change. ( https://review.coreboot.org/21353 )
Change subject: fsp1_0/fsp_util: Rename find_fsp to find_fsp_dummy
......................................................................
Patch Set 1:
(1 comment)
See inline comment
https://review.coreboot.org/#/c/21353/1/src/drivers/intel/fsp1_0/fsp_util.c
File src/drivers/intel/fsp1_0/fsp_util.c:
https://review.coreboot.org/#/c/21353/1/src/drivers/intel/fsp1_0/fsp_util.c@112
PS1, Line 112: "find_fsp:\n\t"
The problem is with this line here. The C function is called find_fsp, so you can't call an inline asm label the same thing.
--
To view, visit https://review.coreboot.org/21353
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84c152f9a580fdfc40e9f6e998d2d6484b7f47df
Gerrit-Change-Number: 21353
Gerrit-PatchSet: 1
Gerrit-Owner: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 03 Sep 2017 01:00:55 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170903/4e9a6363/attachment.html>
More information about the coreboot-gerrit
mailing list