[coreboot-gerrit] Change in coreboot[master]: intel/skylake: nhlt: Add capture format for IV feedback from max98927

[harsha p (Code Review)]

Hello HARSHAPRIYA N,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/21340

to review the following change.


Change subject: intel/skylake: nhlt: Add capture format for IV feedback from max98927
......................................................................

intel/skylake: nhlt: Add capture format for IV feedback from max98927

This changelist adds the capture format to be set for max98927. The
nhlt blob is the same but the format params for capture are different
from the render.

BUG=b:36724448
TEST=IV feedback data is of good quality

Change-Id: I135cf4479e89cd2046ff46027f94c0f71aed650e
Signed-off-by: Harsha Priya <harshapriya.n at intel.com>
---
M src/soc/intel/skylake/nhlt/max98927.c
1 file changed, 20 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/21340/1

diff --git a/src/soc/intel/skylake/nhlt/max98927.c b/src/soc/intel/skylake/nhlt/max98927.c
index 8b14df7..9a20cd8 100644
--- a/src/soc/intel/skylake/nhlt/max98927.c
+++ b/src/soc/intel/skylake/nhlt/max98927.c
@@ -36,6 +36,17 @@
 	},
 };
 
+static const struct nhlt_format_config max98927_capture_formats[] = {
+	/* 48 KHz 16-bits per sample. */
+	{
+		.num_channels = 4,
+		.sample_freq_khz = 48,
+		.container_bits_per_sample = 32,
+		.valid_bits_per_sample = 16,
+		.speaker_mask = SPEAKER_FRONT_LEFT | SPEAKER_FRONT_RIGHT | SPEAKER_BACK_LEFT | SPEAKER_BACK_RIGHT,
+		.settings_file = "max98927-render-2ch-48khz-16b.bin",
+	},
+};
 static const struct nhlt_endp_descriptor max98927_descriptors[] = {
 	{
 		.link = NHLT_LINK_SSP,
@@ -46,6 +57,15 @@
 		.formats = max98927_render_formats,
 		.num_formats = ARRAY_SIZE(max98927_render_formats),
 	},
+	{
+		.link = NHLT_LINK_SSP,
+		.device = NHLT_SSP_DEV_I2S,
+		.direction = NHLT_DIR_CAPTURE,
+		.vid = NHLT_VID,
+		.did = NHLT_DID_SSP,
+		.formats = max98927_capture_formats,
+		.num_formats = ARRAY_SIZE(max98927_capture_formats),
+	},
 };
 
 int nhlt_soc_add_max98927(struct nhlt *nhlt, int hwlink)

-- 
To view, visit https://review.coreboot.org/21340
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I135cf4479e89cd2046ff46027f94c0f71aed650e
Gerrit-Change-Number: 21340
Gerrit-PatchSet: 1
Gerrit-Owner: harsha p <harsha.p.n at intel.corp-partner.google.com>
Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170902/7f4292e1/attachment.html>