[coreboot-gerrit] Change in coreboot[master]: google/gru: Re-enable 3V rail GPIO on Scarlet

Julius Werner (Code Review) gerrit at coreboot.org
Sat Sep 2 02:36:43 CEST 2017


Hello Lin Huang, David Schneider, Philip Chen, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/21328

to look at the new patch set (#2).

Change subject: google/gru: Re-enable 3V rail GPIO on Scarlet
......................................................................

google/gru: Re-enable 3V rail GPIO on Scarlet

We've decided to move control for the 3.0V rail (technically 3.3V on
Scarlet, but who cares about millivolts) back to a GPIO on the AP for
Scarlet rev2. This patch adds the necessary code to enable it and make
ARM TF aware of its existence. Since the pin had previously not been
connected to anything, we shouldn't really need to guard this by board
ID... older Scarlets will just be twiddling an empty pin.

Change-Id: I6037aa486b50119f2c7b859b966cadc3686e3459
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M src/mainboard/google/gru/board.h
M src/mainboard/google/gru/bootblock.c
M src/mainboard/google/gru/mainboard.c
3 files changed, 23 insertions(+), 34 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/21328/2
-- 
To view, visit https://review.coreboot.org/21328
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6037aa486b50119f2c7b859b966cadc3686e3459
Gerrit-Change-Number: 21328
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: David Schneider <dnschneid at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Philip Chen <philipchen at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170902/3e28e011/attachment.html>


More information about the coreboot-gerrit mailing list