[coreboot-gerrit] Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout

Bill XIE (Code Review) gerrit at coreboot.org
Fri Sep 1 16:19:48 CEST 2017


Hello Nicola Corna, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/21315

to look at the new patch set (#4).

Change subject: ifdtool: refactor region_name(s) and new_layout
......................................................................

ifdtool: refactor region_name(s) and new_layout

The feature "--newlayout" is designed to use scheme "right-align"
to copy every regions since its birstday
(change I0e0925a725c40fa44d8c4b6e86552028779d0523), but such
scheme may be only valid for the bios region. For example, it will
cut off the starting chunk of the me region when attempting to shrink
it, according to https://github.com/corna/me_cleaner/issues/58 .

In this commit, I add a member "dir" to "struct region_info" (former
"struct region_name" to record the alignment direction of the region,
and for now, only bios region uses "right-align". (ME region should
use "left-align", according to me_cleaner's practice)

Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf
Signed-off-by: Bill XIE <persmule at gmail.com>
---
M util/ifdtool/ifdtool.c
M util/ifdtool/ifdtool.h
2 files changed, 101 insertions(+), 36 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/21315/4
-- 
To view, visit https://review.coreboot.org/21315
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf
Gerrit-Change-Number: 21315
Gerrit-PatchSet: 4
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170901/9d906a21/attachment.html>


More information about the coreboot-gerrit mailing list