[coreboot-gerrit] Change in coreboot[master]: mainboard/google/soraka: Remove wacom digitizer
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Fri Sep 1 04:23:44 CEST 2017
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/21309 )
Change subject: mainboard/google/soraka: Remove wacom digitizer
......................................................................
Patch Set 1:
(4 comments)
Thanks for picking this up. I was planning to get it done this week. :)
https://review.coreboot.org/#/c/21309/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/21309/1//COMMIT_MSG@14
PS1, Line 14: signed
Uppercase s. "Signed-off-by"
https://review.coreboot.org/#/c/21309/1/src/mainboard/google/poppy/variants/soraka/devicetree.cb
File src/mainboard/google/poppy/variants/soraka/devicetree.cb:
https://review.coreboot.org/#/c/21309/1/src/mainboard/google/poppy/variants/soraka/devicetree.cb@207
PS1, Line 207: # Pen
: register "i2c_voltage[3]" = "I2C_VOLTAGE_1V8"
Remove this.
https://review.coreboot.org/#/c/21309/1/src/mainboard/google/poppy/variants/soraka/devicetree.cb@246
PS1, Line 246: PchSerialIoPci
PchSerialIoDisabled
https://review.coreboot.org/#/c/21309/1/src/mainboard/google/poppy/variants/soraka/devicetree.cb@301
PS1, Line 301: on
off
--
To view, visit https://review.coreboot.org/21309
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5a1b9ece6fc9a9443477c7a7aa77dbcdf6a703
Gerrit-Change-Number: 21309
Gerrit-PatchSet: 1
Gerrit-Owner: Wisley Chen <wisley.chen at quantatw.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 01 Sep 2017 02:23:44 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170901/6f0fb3f9/attachment.html>
More information about the coreboot-gerrit
mailing list