[coreboot-gerrit] Change in coreboot[master]: cbfstool: Add '-p' option to specify the order

Julius Werner (Code Review) gerrit at coreboot.org
Tue Oct 31 03:25:13 CET 2017


Julius Werner has posted comments on this change. ( https://review.coreboot.org/22239 )

Change subject: cbfstool: Add '-p' option to specify the order
......................................................................


Patch Set 1:

Is it really necessary to add a new command for this super specific (and already kinda hacky) use case? You should be able to achieve the same thing with -b by just providing the right offset at the end of your target file.


-- 
To view, visit https://review.coreboot.org/22239
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64bc54fd10a453b4da467bc69d9590e61b0f7ead
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 1
Gerrit-Owner: Daisuke Nojiri <dnojiri at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 31 Oct 2017 02:25:13 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171031/65bab56a/attachment.html>


More information about the coreboot-gerrit mailing list