[coreboot-gerrit] Change in coreboot[master]: mb/google/soraka: update pad reset config from DEEP to RSMRST

Divya Chellappa (Code Review) gerrit at coreboot.org
Mon Oct 30 14:39:10 CET 2017


Divya Chellappa has uploaded this change for review. ( https://review.coreboot.org/22174


Change subject: mb/google/soraka: update pad reset config from DEEP to RSMRST
......................................................................

mb/google/soraka: update pad reset config from DEEP to RSMRST

 In skylake based platforms, setting GPIO pad reset config
 to DEEP will reset the gpio configuration across warm reset,
 set it to RSMRST to preserve the configuration across warm resets.

 BUG=b:64386481
 BRANCH=none
 TEST=verified that configuration are preserved across warm/cold
 reboot in debug prints

Change-Id: I38940b7c7d71e60bf0e51d6978a00be148ad61bc
Signed-off-by: Divya Chellap <divya.chellappa at intel.com>
---
M src/mainboard/google/poppy/variants/soraka/gpio.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/22174/3

diff --git a/src/mainboard/google/poppy/variants/soraka/gpio.c b/src/mainboard/google/poppy/variants/soraka/gpio.c
index cd1258d..d085859 100644
--- a/src/mainboard/google/poppy/variants/soraka/gpio.c
+++ b/src/mainboard/google/poppy/variants/soraka/gpio.c
@@ -370,7 +370,7 @@
 /* Early pad configuration in bootblock */
 static const struct pad_config early_gpio_table[] = {
 	/* B8  : SRCCLKREQ3# ==> WLAN_PE_RST */
-	PAD_CFG_GPO(GPP_B8, 0, DEEP),
+	PAD_CFG_GPO(GPP_B8, 0, RSMRST),
 
 #if IS_ENABLED(CONFIG_POPPY_USE_SPI_TPM)
 	/* B15 : GSPI0_CS# ==> PCH_SPI_H1_3V3_CS_L */
@@ -425,3 +425,5 @@
 	*num = ARRAY_SIZE(cros_gpios);
 	return cros_gpios;
 }
+
+

-- 
To view, visit https://review.coreboot.org/22174
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38940b7c7d71e60bf0e51d6978a00be148ad61bc
Gerrit-Change-Number: 22174
Gerrit-PatchSet: 3
Gerrit-Owner: Divya Chellappa <divya.chellappa at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171030/13b086e7/attachment.html>


More information about the coreboot-gerrit mailing list