[coreboot-gerrit] Change in coreboot[master]: util/*: don't strip executables

Patrick Georgi (Code Review) gerrit at coreboot.org
Sat Oct 28 18:20:16 CEST 2017


Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/22213


Change subject: util/*: don't strip executables
......................................................................

util/*: don't strip executables

Users can do it if they need it, but we shouldn't force it on them.

Change-Id: I08007d68a79c302d8f3ca4ed0837ee96d8d3eb1e
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
M util/k8resdump/Makefile
M util/nvramtool/Makefile
2 files changed, 0 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/22213/1

diff --git a/util/k8resdump/Makefile b/util/k8resdump/Makefile
index 7847861..e260351 100644
--- a/util/k8resdump/Makefile
+++ b/util/k8resdump/Makefile
@@ -16,7 +16,6 @@
 PROGRAM = k8resdump
 
 CC      = gcc
-STRIP	= strip
 INSTALL = /usr/bin/install
 PREFIX  = /usr/local
 #CFLAGS  = -O2 -g -Wall -Werror
@@ -26,7 +25,6 @@
 LDFLAGS = -lpci
 else
 LDFLAGS = -lpci -lz -static
-STRIP_ARGS = -s
 endif
 
 OBJS = k8resdump.o
@@ -35,7 +33,6 @@
 
 $(PROGRAM): $(OBJS)
 	$(CC) -o $(PROGRAM) $(OBJS) $(LDFLAGS)
-	$(STRIP) $(STRIP_ARGS) $(PROGRAM)
 
 clean:
 	rm -f *.o *~
diff --git a/util/nvramtool/Makefile b/util/nvramtool/Makefile
index b92adda..bb623bb 100644
--- a/util/nvramtool/Makefile
+++ b/util/nvramtool/Makefile
@@ -17,7 +17,6 @@
 PROGRAM = nvramtool
 
 CC      = gcc
-STRIP	= strip
 INSTALL = /usr/bin/install
 PREFIX  = /usr/local
 CFLAGS  = -O2 -g -Wall -W -I. -DCMOS_HAL=1
@@ -47,7 +46,6 @@
 
 $(PROGRAM): $(OBJS)
 	$(CC) -o $(PROGRAM) $(OBJS) $(LDFLAGS) $(CFLAGS)
-	$(STRIP) $(STRIP_ARGS) $(PROGRAM)
 
 clean:
 	rm -f $(PROGRAM) $(OBJS) junit.xml

-- 
To view, visit https://review.coreboot.org/22213
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08007d68a79c302d8f3ca4ed0837ee96d8d3eb1e
Gerrit-Change-Number: 22213
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171028/7970f572/attachment.html>


More information about the coreboot-gerrit mailing list