[coreboot-gerrit] Change in coreboot[master]: build system: Deal with wildcard in subdirs-y

Patrick Georgi (Code Review) gerrit at coreboot.org
Sat Oct 28 11:28:43 CEST 2017


Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/22208


Change subject: build system: Deal with wildcard in subdirs-y
......................................................................

build system: Deal with wildcard in subdirs-y

This enabled subdirs-y += * to work properly.

BUG=b:68384012
BRANCH=none
TEST=Run `abuild -t GOOGLE_CORAL -p none` and observe that
`find coreboot-builds/GOOGLE_CORAL -type d -name '\*'` doesn't return
any files called '*'.

Change-Id: Iba7866db339ae9b4063c4b4377500652eb1be13d
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/22208/1

diff --git a/Makefile b/Makefile
index dedf688..33b12f8 100644
--- a/Makefile
+++ b/Makefile
@@ -236,7 +236,7 @@
 			$$(abspath $$(subst $(dir $(1))/,/,$$(addprefix $(dir $(1)),$$($(class)-y)))))))) \
 	$(foreach special,$(special-classes), \
 		$(foreach item,$($(special)-y), $(call $(special)-handler,$(dir $(1)),$(item)))) \
-	$(eval subdirs+=$$(subst $(CURDIR)/,,$$(abspath $$(addprefix $(dir $(1)),$$(subdirs-y)))))
+	$(eval subdirs+=$$(subst $(CURDIR)/,,$$(wildcard $$(abspath $$(addprefix $(dir $(1)),$$(subdirs-y))))))
 
 # For each path in $(subdirs) call includemakefiles
 # Repeat until subdirs is empty

-- 
To view, visit https://review.coreboot.org/22208
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba7866db339ae9b4063c4b4377500652eb1be13d
Gerrit-Change-Number: 22208
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171028/7551998e/attachment.html>


More information about the coreboot-gerrit mailing list