[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: remove duplicate power_state migration

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu Oct 26 10:34:46 CEST 2017


Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/22182


Change subject: soc/intel/cannonlake: remove duplicate power_state migration
......................................................................

soc/intel/cannonlake: remove duplicate power_state migration

Common PMC code comes with its own.

Change-Id: Ic055f046a2da1c56af4cc7936602d6191ffe7eef
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
M src/soc/intel/cannonlake/romstage/power_state.c
1 file changed, 0 insertions(+), 17 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/22182/1

diff --git a/src/soc/intel/cannonlake/romstage/power_state.c b/src/soc/intel/cannonlake/romstage/power_state.c
index cd9a3bc..b62e5fd 100644
--- a/src/soc/intel/cannonlake/romstage/power_state.c
+++ b/src/soc/intel/cannonlake/romstage/power_state.c
@@ -32,23 +32,6 @@
 	return ps->prev_sleep_state;
 }
 
-static void migrate_power_state(int is_recovery)
-{
-	struct chipset_power_state *ps_cbmem;
-	struct chipset_power_state *ps_car;
-
-	ps_car = pmc_get_power_state();
-	ps_cbmem = cbmem_add(CBMEM_ID_POWER_STATE, sizeof(*ps_cbmem));
-
-	if (ps_cbmem == NULL) {
-		printk(BIOS_DEBUG, "Not adding power state to cbmem!\n");
-		return;
-	}
-	memcpy(ps_cbmem, ps_car, sizeof(*ps_cbmem));
-}
-
-ROMSTAGE_CBMEM_INIT_HOOK(migrate_power_state)
-
 static inline int deep_s3_enabled(void)
 {
 	uint32_t deep_s3_pol;

-- 
To view, visit https://review.coreboot.org/22182
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic055f046a2da1c56af4cc7936602d6191ffe7eef
Gerrit-Change-Number: 22182
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171026/901de4ae/attachment.html>


More information about the coreboot-gerrit mailing list