[coreboot-gerrit] Change in coreboot[master]: ec/lenovo/h8: Clear EC output queue after enablement

Bill XIE (Code Review) gerrit at coreboot.org
Thu Oct 26 09:02:15 CEST 2017


Bill XIE has uploaded this change for review. ( https://review.coreboot.org/22181


Change subject: ec/lenovo/h8: Clear EC output queue after enablement
......................................................................

ec/lenovo/h8: Clear EC output queue after enablement

Sometimes (observed on Thinkpad T400s during cold boot)
a few (only one observed) garbage bytes may detained in
the output queue of EC after power up, and they should
be cleared otherwise later communications will be
disrupted.

Change-Id: Id1733f7350232d0b10ac0d1bc912b62e7fa4da75
Signed-off-by: Bill XIE <persmule at gmail.com>
---
M src/ec/lenovo/h8/h8.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/22181/1

diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index 882ac02..3442f68 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -196,6 +196,7 @@
 
 	dev->ops = &h8_dev_ops;
 
+	ec_clear_out_queue();
 	h8_log_ec_version();
 
 	/* Always enable I/O range 0x1600-0x160f and thermal management */

-- 
To view, visit https://review.coreboot.org/22181
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1733f7350232d0b10ac0d1bc912b62e7fa4da75
Gerrit-Change-Number: 22181
Gerrit-PatchSet: 1
Gerrit-Owner: Bill XIE <persmule at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171026/0725df7f/attachment-0001.html>


More information about the coreboot-gerrit mailing list