[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Remove RunFcnOnAllAps() callback

[Marc Jones (Code Review)]

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/22150


Change subject: soc/amd/common: Remove RunFcnOnAllAps() callback
......................................................................

soc/amd/common: Remove RunFcnOnAllAps() callback

RunFcnOnAllAps() is not a callback, but a AGESA call. This is a mistake
in the AGESA spec and the function is in the wrong section.

bug=b:66690176, b:67210418
branch=none
test=none

Change-Id: I900e7db13a58e73a7b054e06088bc77c89445876
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/soc/amd/common/BiosCallOuts.h
M src/soc/amd/common/def_callouts.c
2 files changed, 0 insertions(+), 11 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/22150/1

diff --git a/src/soc/amd/common/BiosCallOuts.h b/src/soc/amd/common/BiosCallOuts.h
index ef853fa..8ee7463 100644
--- a/src/soc/amd/common/BiosCallOuts.h
+++ b/src/soc/amd/common/BiosCallOuts.h
@@ -49,7 +49,6 @@
 							VOID *ConfigPrt);
 
 AGESA_STATUS agesa_ReadSpd(UINT32 Func, UINTN Data, VOID *ConfigPtr);
-AGESA_STATUS agesa_RunFcnOnAllAps(UINT32 Func, UINTN Data, VOID *ConfigPtr);
 AGESA_STATUS agesa_LateRunApTask(UINT32 Func, UINTN Data, VOID *ConfigPtr);
 AGESA_STATUS agesa_PcieSlotResetControl(UINT32 Func, UINTN Data,
 							VOID *ConfigPtr);
diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c
index 6e46f69..fd3b5e9 100644
--- a/src/soc/amd/common/def_callouts.c
+++ b/src/soc/amd/common/def_callouts.c
@@ -39,7 +39,6 @@
 	{ AGESA_READ_SPD,                 agesa_ReadSpd },
 	{ AGESA_RUNFUNC_ONAP,             agesa_RunFuncOnAp },
 	{ AGESA_RUNFUNC_ON_ALL_APS,       agesa_RunFcnOnAllAps },
-	{ AMD_LATE_RUN_AP_TASK,           agesa_LateRunApTask },
 	{ AGESA_GNB_PCIE_SLOT_RESET,      agesa_PcieSlotResetControl },
 	{ AGESA_WAIT_FOR_ALL_APS,         agesa_WaitForAllApsFinished },
 	{ AGESA_IDLE_AN_AP,               agesa_IdleAnAp },
@@ -162,15 +161,6 @@
 
 	return Status;
 }
-
-AGESA_STATUS agesa_LateRunApTask(UINT32 Func, UINTN Data, VOID *ConfigPtr)
-{
-	printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__);
-	AGESA_STATUS Status = AGESA_UNSUPPORTED;
-
-	return Status;
-}
-
 
 AGESA_STATUS agesa_PcieSlotResetControl(UINT32 Func, UINTN Data,
 	VOID *ConfigPtr)

-- 
To view, visit https://review.coreboot.org/22150
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I900e7db13a58e73a7b054e06088bc77c89445876
Gerrit-Change-Number: 22150
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171024/e0fd0fe1/attachment.html>