[coreboot-gerrit] Change in coreboot[master]: include: Deactivate timestamp_get if kconfig option not set

Philipp Deppenwiese (Code Review) gerrit at coreboot.org
Tue Oct 24 22:11:13 CEST 2017


Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22147 )

Change subject: include: Deactivate timestamp_get if kconfig option not set
......................................................................


Patch Set 9:

(1 comment)

https://review.coreboot.org/#/c/22147/9/src/include/timestamp.h
File src/include/timestamp.h:

https://review.coreboot.org/#/c/22147/9/src/include/timestamp.h@62
PS9, Line 62: uint64_t timestamp_get(void);
> We can't move this declaration up with the other guarded functions?
Yep there is a collision with CONFIG_EARLY_CBMEM_INIT || ! __PRE_RAM__ :-/



-- 
To view, visit https://review.coreboot.org/22147
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ac63ba7e4485e26dc35fb5a68b1811f6df2f91d
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 9
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 24 Oct 2017 20:11:13 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171024/8c6be6e2/attachment.html>


More information about the coreboot-gerrit mailing list