[coreboot-gerrit] Change in coreboot[master]: mainboard/google/coral: Add USB2 phy setting override for Astronaut

[Ren Kuo (Code Review)]

Hello Ren Kuo,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/22135

to review the following change.


Change subject: mainboard/google/coral: Add USB2 phy setting override for Astronaut
......................................................................

mainboard/google/coral: Add USB2 phy setting override for Astronaut

In order to pass type C USB2 eye diagram for sku Astronaut,
USB2 port#1 PHY register needs to be overridden.

sku ID:0,1 Astronaut (USB)
port#1:
PERPORTPETXISET = 7
PERPORTTXISET = 2

sku ID:61,62 Astronaut (LTE)
port#1:
PERPORTPETXISET = 7
PERPORTTXISET = 5

BUG=b:64880573
BRANCH=master
TEST=emerge-coral coreboot chromeos-bootimage

Change-Id: Icf5c9e5f4dae15630ec4d6ca6648cae78ca910c6
Signed-off-by: Ren Kuo <ren.kuo at quantatw.com>
---
M src/mainboard/google/reef/variants/coral/mainboard.c
1 file changed, 14 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/22135/1

diff --git a/src/mainboard/google/reef/variants/coral/mainboard.c b/src/mainboard/google/reef/variants/coral/mainboard.c
index 805c153..853276e 100644
--- a/src/mainboard/google/reef/variants/coral/mainboard.c
+++ b/src/mainboard/google/reef/variants/coral/mainboard.c
@@ -21,8 +21,12 @@
 #include <soc/intel/common/vbt.h>
 
 enum {
+        SKU_0_ASTRONAUT = 0,
+        SKU_1_ASTRONAUT = 1,
 	SKU_2_SANTA = 2,
 	SKU_3_SANTA = 3,
+        SKU_61_ASTRONAUT = 61,
+        SKU_62_ASTRONAUT = 62,
 	SKU_160_NASHER = 160,
 	SKU_161_NASHER = 161,
 	SKU_162_NASHER = 162,
@@ -60,11 +64,21 @@
 	sku_id = variant_board_sku();
 
 	switch (sku_id) {
+        case SKU_0_ASTRONAUT:
+        case SKU_1_ASTRONAUT:
+		cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7;
+		cfg->usb2eye[1].Usb20PerPortTxiSet = 2;
+		break;
 	case SKU_2_SANTA:
 	case SKU_3_SANTA:
 		cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7;
 		cfg->usb2eye[1].Usb20PerPortTxiSet = 2;
 		break;
+        case SKU_61_ASTRONAUT:
+        case SKU_62_ASTRONAUT:
+		cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7;
+		cfg->usb2eye[1].Usb20PerPortTxiSet = 5;
+                break;
 	default:
 		break;
 	}

-- 
To view, visit https://review.coreboot.org/22135
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf5c9e5f4dae15630ec4d6ca6648cae78ca910c6
Gerrit-Change-Number: 22135
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo <ren.kuo at quanta.corp-partner.google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo at quantatw.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171023/e47442ab/attachment.html>