[coreboot-gerrit] Change in coreboot[master]: mainboard/intel/cannonlake_rvp: Enable variant gpio configuration

John Zhao (Code Review) gerrit at coreboot.org
Sat Oct 21 02:51:44 CEST 2017


Hello John Zhao,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/22129

to review the following change.


Change subject: mainboard/intel/cannonlake_rvp: Enable variant gpio configuration
......................................................................

mainboard/intel/cannonlake_rvp: Enable variant gpio configuration

This patch refers to variant_gpio_table for board gpio configuration.

Change-Id: If5b4c20ceccb32fc1ab4246482d8fecb491777c4
Signed-off-by: John Zhao <john.zhao at intel.com>
---
M src/mainboard/intel/cannonlake_rvp/Makefile.inc
A src/mainboard/intel/cannonlake_rvp/mainboard.c
2 files changed, 34 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/22129/1

diff --git a/src/mainboard/intel/cannonlake_rvp/Makefile.inc b/src/mainboard/intel/cannonlake_rvp/Makefile.inc
index 247f171..7e82196 100644
--- a/src/mainboard/intel/cannonlake_rvp/Makefile.inc
+++ b/src/mainboard/intel/cannonlake_rvp/Makefile.inc
@@ -24,6 +24,7 @@
 romstage-$(CONFIG_CHROMEOS) += chromeos.c
 
 ramstage-$(CONFIG_CHROMEOS) += chromeos.c
+ramstage-y += mainboard.c
 
 smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
 subdirs-y += variants/baseboard
diff --git a/src/mainboard/intel/cannonlake_rvp/mainboard.c b/src/mainboard/intel/cannonlake_rvp/mainboard.c
new file mode 100644
index 0000000..33b0bc9
--- /dev/null
+++ b/src/mainboard/intel/cannonlake_rvp/mainboard.c
@@ -0,0 +1,33 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2017 Intel Corp.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <baseboard/variants.h>
+#include <device/device.h>
+#include <soc/gpio.h>
+#include <vendorcode/google/chromeos/chromeos.h>
+#include <variant/gpio.h>
+
+static void mainboard_init(void *chip_info)
+{
+	const struct pad_config *pads;
+	size_t num;
+
+	pads = variant_gpio_table(&num);
+	gpio_configure_pads(pads, num);
+}
+
+struct chip_operations mainboard_ops = {
+	.init = mainboard_init,
+};

-- 
To view, visit https://review.coreboot.org/22129
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5b4c20ceccb32fc1ab4246482d8fecb491777c4
Gerrit-Change-Number: 22129
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao at intel.corp-partner.google.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171021/e706ad4a/attachment.html>


More information about the coreboot-gerrit mailing list