[coreboot-gerrit] Change in coreboot[master]: cr50_enable_update: Adding printk before EC reboot

Shelley Chen (Code Review) gerrit at coreboot.org
Fri Oct 20 17:31:40 CEST 2017


Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/22120


Change subject: cr50_enable_update: Adding printk before EC reboot
......................................................................

cr50_enable_update: Adding printk before EC reboot

Add printout before EC reboots during a cr50 update to clarify
that failure is due to EC reboot rather than cr50 reboot.  Ran
into a situation where DUT shut down during cr50 update and
the EC was the culprit.

BUG=None
BRANCH=None
TEST=None

Change-Id: I54813fec123de69604d1da4dfc65eaeb77d1662e
Signed-off-by: Shelley Chen <shchen at chromium.org>
---
M src/vendorcode/google/chromeos/cr50_enable_update.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/22120/1

diff --git a/src/vendorcode/google/chromeos/cr50_enable_update.c b/src/vendorcode/google/chromeos/cr50_enable_update.c
index e962f19..2b9f66a 100644
--- a/src/vendorcode/google/chromeos/cr50_enable_update.c
+++ b/src/vendorcode/google/chromeos/cr50_enable_update.c
@@ -61,6 +61,7 @@
 
 	if (IS_ENABLED(CONFIG_POWER_OFF_ON_CR50_UPDATE)) {
 		if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC))
+			printk(BIOS_INFO, "Rebooting EC.\n");
 			google_chromeec_reboot(0, EC_REBOOT_HIBERNATE,
 				EC_REBOOT_FLAG_ON_AP_SHUTDOWN);
 		poweroff();

-- 
To view, visit https://review.coreboot.org/22120
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54813fec123de69604d1da4dfc65eaeb77d1662e
Gerrit-Change-Number: 22120
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171020/c120643b/attachment.html>


More information about the coreboot-gerrit mailing list