[coreboot-gerrit] Change in coreboot[master]: Makefile.inc: remove '--global' flag from config check for gitconfig ...

Chris Ching (Code Review) gerrit at coreboot.org
Thu Oct 19 19:39:24 CEST 2017


Chris Ching has uploaded this change for review. ( https://review.coreboot.org/22109


Change subject: Makefile.inc: remove '--global' flag from config check for gitconfig rule
......................................................................

Makefile.inc: remove '--global' flag from config check for gitconfig rule

As long as user.name and user.email are set, gitconfig should pass. This
handles if values are only set for the local repo, or if values are
stored in ~/.config/git/config

Change-Id: Ie01e7a155f9e6db35d5991e4303aad85fb277a06
Signed-off-by: Chris Ching <chingcodes at google.com>
---
M Makefile.inc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/22109/1

diff --git a/Makefile.inc b/Makefile.inc
index fefc8d1..ea56a09 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -595,7 +595,7 @@
 	git config remote.origin.push HEAD:refs/for/master
 	git config alias.sup '!git submodule update --remote --rebase && git submodule update --init --checkout'
 	git config alias.sup-destroy '!git submodule deinit --force "$$(git rev-parse --show-toplevel)"; git submodule init && git submodule update --checkout'
-	(git config --global --includes user.name >/dev/null && git config --global --includes user.email >/dev/null) || (printf 'Please configure your name and email in git:\n\n git config --global user.name "Your Name Comes Here"\n git config --global user.email your.email at example.com\n'; exit 1)
+	(git config --includes user.name >/dev/null && git config --includes user.email >/dev/null) || (printf 'Please configure your name and email in git:\n\n git config --global user.name "Your Name Comes Here"\n git config --global user.email your.email at example.com\n'; exit 1)
 
 include util/crossgcc/Makefile.inc
 

-- 
To view, visit https://review.coreboot.org/22109
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie01e7a155f9e6db35d5991e4303aad85fb277a06
Gerrit-Change-Number: 22109
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Ching <chingcodes at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171019/d115a905/attachment.html>


More information about the coreboot-gerrit mailing list