[coreboot-gerrit] Change in coreboot[master]: util/genbuild_h: improve robustness against corrupt .git directories

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu Oct 19 09:57:28 CEST 2017


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/22107

to look at the new patch set (#2).

Change subject: util/genbuild_h: improve robustness against corrupt .git directories
......................................................................

util/genbuild_h: improve robustness against corrupt .git directories

The new test lets git check if $top is actually a git repo, instead of
just looking for clues.

BUG=chromium:776174
BRANCH=none
TEST=`mv .git .foo; mkdir .git; util/genbuild_h/genbuild_h.sh` provides
a valid build.h instead of failing because git is unhappy about the
.git directory.

Change-Id: I7fcc64d66e0b59fca1479b4c142fd0559aa984f4
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
M util/genbuild_h/genbuild_h.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/22107/2
-- 
To view, visit https://review.coreboot.org/22107
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fcc64d66e0b59fca1479b4c142fd0559aa984f4
Gerrit-Change-Number: 22107
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171019/35450670/attachment.html>


More information about the coreboot-gerrit mailing list