[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add weak method for vboot2, fix missing select

Philipp Deppenwiese (Code Review) gerrit at coreboot.org
Thu Oct 19 02:37:16 CEST 2017


Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22102 )

Change subject: security/vboot: Add weak method for vboot2, fix missing select
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/22102/1/src/security/vboot/Kconfig
File src/security/vboot/Kconfig:

https://review.coreboot.org/#/c/22102/1/src/security/vboot/Kconfig@24
PS1, Line 24: 	select COLLECT_TIMESTAMPS
> Things don't work if this isn't here? Or you just want all vboot usages to 
The timestamp_get function is hardcoded in the vboot code. Should I fix it ?



-- 
To view, visit https://review.coreboot.org/22102
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b1555bd93e1605e04d5c3ea6a752eb1459e426e
Gerrit-Change-Number: 22102
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 19 Oct 2017 00:37:16 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171019/914ae909/attachment.html>


More information about the coreboot-gerrit mailing list