[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add weak method for vboot2, fix missing select

Philipp Deppenwiese (Code Review) gerrit at coreboot.org
Wed Oct 18 15:35:31 CEST 2017


Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/22102


Change subject: security/vboot: Add weak method for vboot2, fix missing select
......................................................................

security/vboot: Add weak method for vboot2, fix missing select

In order to make VBOOT2 independent from the CHROMEOS
kconfig option a weak method for get_write_protect_state
is required.

Also timestamps select was missing for the vboot
kconfig option.

Change-Id: I3b1555bd93e1605e04d5c3ea6a752eb1459e426e
Signed-off-by: Philipp Deppenwiese <zaolin at das-labor.org>
---
M src/security/vboot/Kconfig
M src/security/vboot/bootmode.c
2 files changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/22102/1

diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig
index d5b5de2..045f446 100644
--- a/src/security/vboot/Kconfig
+++ b/src/security/vboot/Kconfig
@@ -21,6 +21,7 @@
 	select TPM2 if MAINBOARD_HAS_TPM2 && !VBOOT_MOCK_SECDATA
 	select TPM_INIT_FAILURE_IS_FATAL if PC80_SYSTEM && LPC_TPM
 	select SKIP_TPM_STARTUP_ON_NORMAL_BOOT if PC80_SYSTEM && LPC_TPM
+	select COLLECT_TIMESTAMPS
 	depends on HAVE_HARD_RESET
 	help
 	  Enabling VBOOT will use vboot to verify the components of the firmware
diff --git a/src/security/vboot/bootmode.c b/src/security/vboot/bootmode.c
index 834bc48..bddeafb 100644
--- a/src/security/vboot/bootmode.c
+++ b/src/security/vboot/bootmode.c
@@ -169,3 +169,8 @@
 
 	return 0;
 }
+
+int __attribute__((weak)) get_write_protect_state(void)
+{
+	return 0;
+}

-- 
To view, visit https://review.coreboot.org/22102
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b1555bd93e1605e04d5c3ea6a752eb1459e426e
Gerrit-Change-Number: 22102
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171018/fe5281bc/attachment.html>


More information about the coreboot-gerrit mailing list