[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Support logging wake source in SMM

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed Oct 18 01:11:44 CEST 2017


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22086


Change subject: soc/intel/skylake: Support logging wake source in SMM
......................................................................

soc/intel/skylake: Support logging wake source in SMM

This change adds support for logging wake source information in gsmi
callbacks. With this change, all the elog logging infrastructure can
be used for S0ix as well as S3 on skylake.

BUG=b:67874513

Change-Id: Ie1f81e956fe0bbe2e5e4c706f27997b7bd30d5e0
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/soc/intel/skylake/Makefile.inc
M src/soc/intel/skylake/elog.c
2 files changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/22086/1

diff --git a/src/soc/intel/skylake/Makefile.inc b/src/soc/intel/skylake/Makefile.inc
index 9a8372b..bc53922 100644
--- a/src/soc/intel/skylake/Makefile.inc
+++ b/src/soc/intel/skylake/Makefile.inc
@@ -72,6 +72,7 @@
 ramstage-$(CONFIG_UART_DEBUG) += uart_debug.c
 ramstage-y += vr_config.c
 
+smm-y += elog.c
 smm-y += gpio.c
 smm-y += pch.c
 smm-y += pmutil.c
diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c
index c015a78..8240457 100644
--- a/src/soc/intel/skylake/elog.c
+++ b/src/soc/intel/skylake/elog.c
@@ -20,6 +20,7 @@
 #include <device/pci_ops.h>
 #include <stdint.h>
 #include <elog.h>
+#include <intelblocks/pmclib.h>
 #include <soc/pci_devs.h>
 #include <soc/pm.h>
 #include <soc/smbus.h>
@@ -382,3 +383,10 @@
 }
 
 BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_EXIT, pch_log_state, NULL);
+
+void elog_gsmi_cb_platform_log_wake_source(void)
+{
+	struct chipset_power_state ps;
+	pmc_fill_pm_reg_info(&ps);
+	pch_log_wake_source(&ps);
+}

-- 
To view, visit https://review.coreboot.org/22086
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1f81e956fe0bbe2e5e4c706f27997b7bd30d5e0
Gerrit-Change-Number: 22086
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171017/67616a13/attachment-0001.html>


More information about the coreboot-gerrit mailing list