[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Use newly added pmc_read_pm1_control

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed Oct 18 01:11:42 CEST 2017


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22082


Change subject: soc/intel/apollolake: Use newly added pmc_read_pm1_control
......................................................................

soc/intel/apollolake: Use newly added pmc_read_pm1_control

BUG=b:67874513

Change-Id: I6d5a76122b7d6e508e5ff3f4099e5d706fb48f9d
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/soc/intel/apollolake/pmutil.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/22082/1

diff --git a/src/soc/intel/apollolake/pmutil.c b/src/soc/intel/apollolake/pmutil.c
index b9ed5b4..5fcefd7 100644
--- a/src/soc/intel/apollolake/pmutil.c
+++ b/src/soc/intel/apollolake/pmutil.c
@@ -86,7 +86,7 @@
  */
 uint32_t soc_get_smi_status(uint32_t generic_sts)
 {
-	if (generic_sts == 0 && !(inl(ACPI_BASE_ADDRESS + PM1_CNT) & SCI_EN)) {
+	if (generic_sts == 0 && !(pmc_read_pm1_control() & SCI_EN)) {
 		uint16_t pm1_sts = inw(ACPI_BASE_ADDRESS + PM1_STS);
 
 		/* Fake PM1 status bit if power button pressed. */

-- 
To view, visit https://review.coreboot.org/22082
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d5a76122b7d6e508e5ff3f4099e5d706fb48f9d
Gerrit-Change-Number: 22082
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171017/987f2bd2/attachment-0001.html>


More information about the coreboot-gerrit mailing list