[coreboot-gerrit] Change in coreboot[master]: drivers/pc80/tpm: add support for SLB9665 TPM2.0 module

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/21983 )

Change subject: drivers/pc80/tpm: add support for SLB9665 TPM2.0 module
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

@Kamil could you please fix the remaining resume issue ?

https://review.coreboot.org/#/c/21983/1/src/drivers/pc80/tpm/romstage.c
File src/drivers/pc80/tpm/romstage.c:

https://review.coreboot.org/#/c/21983/1/src/drivers/pc80/tpm/romstage.c@227
PS1, Line 227: tpm_resume_cmd.buffer
> Is the resume command different between 1.2 and 2.0 ?
Woah the new spec is even more ugly then the 1.2 . Anyway the tpm2 resume commmand should be "{0x80, 0x01, 0x0, 0x0, 0x0, 0xc, 0x0, 0x0, 0x01, 0x44, 0x0, 0x1 }" as far as I know.



-- 
To view, visit https://review.coreboot.org/21983
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic20b9a65ef6a4ee392a9352f7c9bf01b2496f482
Gerrit-Change-Number: 21983
Gerrit-PatchSet: 1
Gerrit-Owner: Kamil Wcisło <kamil.wcislo at 3mdeb.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 13 Oct 2017 16:29:17 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171013/8734e567/attachment.html>