[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Make all AGESA reset requests immediate

Marc Jones (Code Review) gerrit at coreboot.org
Thu Oct 12 04:34:01 CEST 2017


Marc Jones has uploaded this change for review. ( https://review.coreboot.org/21978


Change subject: amd/stoneyridge: Make all AGESA reset requests immediate
......................................................................

amd/stoneyridge: Make all AGESA reset requests immediate

The AGESA RESET_WHENEVER request were never doing a reset in coreboot.
We don't have a way to collect a whenever and reset at some later time,
so just do the reset immediately.

BUG=b:64719937
BRANCH=none
TEST=Check AGESA reset request in booblock does a reset in the serial
console or ec console.

Change-Id: If2654ec0c5c5dbdcea6fc9374371c3388d29fdc7
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/soc/amd/common/def_callouts.c
1 file changed, 0 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/21978/1

diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c
index 4b71d5b..bad4f58 100644
--- a/src/soc/amd/common/def_callouts.c
+++ b/src/soc/amd/common/def_callouts.c
@@ -76,8 +76,6 @@
 	switch (ResetType) {
 	case WARM_RESET_WHENEVER:
 	case COLD_RESET_WHENEVER:
-		break;
-
 	case WARM_RESET_IMMEDIATELY:
 	case COLD_RESET_IMMEDIATELY:
 		Value = 0x06;

-- 
To view, visit https://review.coreboot.org/21978
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2654ec0c5c5dbdcea6fc9374371c3388d29fdc7
Gerrit-Change-Number: 21978
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171012/29bf6cbd/attachment.html>


More information about the coreboot-gerrit mailing list