[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge/sata.c: Requested cleanup.

Richard Spiegel (Code Review) gerrit at coreboot.org
Thu Oct 12 01:48:59 CEST 2017


Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/21973


Change subject: soc/amd/stoneyridge/sata.c: Requested cleanup.
......................................................................

soc/amd/stoneyridge/sata.c: Requested cleanup.

Execute cleanup requested at code review for Change-Id:
Ib88a868e654ad127be70ecc506f6b90b784f8d1b

BUG=b:62200375

Change-Id: I9058d9102fc8ea0bd03ea089ba98da4590dd3533
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/soc/amd/stoneyridge/sata.c
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/21973/1

diff --git a/src/soc/amd/stoneyridge/sata.c b/src/soc/amd/stoneyridge/sata.c
index c1e5493..3361107 100644
--- a/src/soc/amd/stoneyridge/sata.c
+++ b/src/soc/amd/stoneyridge/sata.c
@@ -35,8 +35,10 @@
 	#define SATA_CAPABILITIES_REG 0xfc
 	#define CFG_CAP_SPM (1<<12)
 
-	volatile u32 *ahci_ptr = (u32 *)(pci_read_config32(dev,
-				AHCI_BASE_ADDRESS_REG) & 0xffffff00);
+	u32 *ahci_ptr = (void *)(uintptr_t)ALIGN_DOWN(
+						pci_read_config32(dev,
+						AHCI_BASE_ADDRESS_REG),
+						256);
 	u32 temp;
 
 	/* unlock the write-protect */
@@ -68,8 +70,6 @@
 };
 
 static const unsigned short pci_device_ids[] = {
-	PCI_DEVICE_ID_AMD_SB900_SATA,
-	PCI_DEVICE_ID_AMD_SB900_SATA_AHCI,
 	PCI_DEVICE_ID_AMD_CZ_SATA,
 	PCI_DEVICE_ID_AMD_CZ_SATA_AHCI,
 	0

-- 
To view, visit https://review.coreboot.org/21973
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9058d9102fc8ea0bd03ea089ba98da4590dd3533
Gerrit-Change-Number: 21973
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171011/30656a7f/attachment-0001.html>


More information about the coreboot-gerrit mailing list