[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add finalized function

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/21943 )

Change subject: soc/intel/cannonlake: Add finalized function
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/21943/1/src/soc/intel/cannonlake/finalize.c
File src/soc/intel/cannonlake/finalize.c:

https://review.coreboot.org/#/c/21943/1/src/soc/intel/cannonlake/finalize.c@4
PS1, Line 4: 2014
> Any reason for 2014 ?
That's from previous files in skylake, I assume we will leave the header untouched?


https://review.coreboot.org/#/c/21943/1/src/soc/intel/cannonlake/finalize.c@99
PS1, Line 99: 	/*TCO Lock down */
> Give a space here.
Done



-- 
To view, visit https://review.coreboot.org/21943
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfa05b50fd76fbaeb856d398918990aedac4c5e6
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Andrex Andraos <andrex.andraos at intel.corp-partner.google.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 11 Oct 2017 18:00:57 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171011/9d41cb10/attachment.html>