[coreboot-gerrit] Change in coreboot[master]: mainboard/lenovo: Add support for the Lenovo ThinkPad X230i

[Yang Jiaxun (Code Review)]

Yang Jiaxun has uploaded this change for review. ( https://review.coreboot.org/21944


Change subject: mainboard/lenovo: Add support for the Lenovo ThinkPad X230i
......................................................................

mainboard/lenovo: Add support for the Lenovo ThinkPad X230i

The ThinkPad x230i have a similar main broad with ThinkPad x230 but it has some different CPUs (SandyBridge i3, SandyBridge Celeron, IvyBridge i3) and the VGA_BIOS_ID differs.
This commit is to support this by using x230's mainboard directory, add a choice for x230i's different CPUs type and setting the VGA_BIOS_ID in Kconfig.

Change-Id: Icbdbc7a08145c4a2dc54a7fb5299cb104dfe6cb9
Signed-off-by: Yang Jiaxun <yjx at flygoat.com>
---
M src/mainboard/lenovo/x230/Kconfig
M src/mainboard/lenovo/x230/Kconfig.name
2 files changed, 26 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/21944/1

diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig
index 39af0e3..357ecfa 100644
--- a/src/mainboard/lenovo/x230/Kconfig
+++ b/src/mainboard/lenovo/x230/Kconfig
@@ -1,4 +1,4 @@
-if BOARD_LENOVO_X230
+if BOARD_LENOVO_X230 || BOARD_LENOVO_X230I
 
 config BOARD_SPECIFIC_OPTIONS # dummy
 	def_bool y
@@ -24,6 +24,24 @@
 
 	# Workaround for EC/KBC IRQ1.
 	select SERIRQ_CONTINUOUS_MODE
+
+choice
+
+	depends on BOARD_LENOVO_X230I
+
+	prompt "X230i CPU TYPE"
+
+	config BROAD_HAVE_SANDYBRIDGE_I3_CPU
+		bool "X230i with SandyBridge i3 CPU"
+		default y
+	
+	config BROAD_HAVE_SANDYBRIDGE_CELERON_CPU
+		bool "X230i with SandyBridge Celeron CPU"
+
+	config BROAD_HAVE_IVYBRIDGE_I3_CPU
+		bool "X230i with IvyBridge i3 CPU"
+
+endchoice
 
 config HAVE_IFD_BIN
 	bool
@@ -55,10 +73,14 @@
 
 config VGA_BIOS_FILE
 	string
+	default "pci8086,0116.rom" if BROAD_HAVE_SANDYBRIDGE_I3_CPU
+	default "pci8086,0106.rom" if BROAD_HAVE_SANDYBRIDGE_CELERON_CPU
 	default "pci8086,0166.rom"
 
 config VGA_BIOS_ID
 	string
+	default "8086,0116" if BROAD_HAVE_SANDYBRIDGE_I3_CPU
+	default "8086,0106" if BROAD_HAVE_SANDYBRIDGE_CELERON_CPU
 	default "8086,0166"
 
 config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
diff --git a/src/mainboard/lenovo/x230/Kconfig.name b/src/mainboard/lenovo/x230/Kconfig.name
index d207653..a571598 100644
--- a/src/mainboard/lenovo/x230/Kconfig.name
+++ b/src/mainboard/lenovo/x230/Kconfig.name
@@ -1,2 +1,5 @@
 config BOARD_LENOVO_X230
 	bool "ThinkPad X230"
+
+config BOARD_LENOVO_X230I
+	bool "ThinkPad X230i"

-- 
To view, visit https://review.coreboot.org/21944
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbdbc7a08145c4a2dc54a7fb5299cb104dfe6cb9
Gerrit-Change-Number: 21944
Gerrit-PatchSet: 1
Gerrit-Owner: Yang Jiaxun <yjx at flygoat.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171011/5ecf69c3/attachment.html>