[coreboot-gerrit] Change in coreboot[master]: [WIP] cpu/x86/mtrr: Optimize hole carving strategy

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21915 )

Change subject: [WIP] cpu/x86/mtrr: Optimize hole carving strategy
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/21915/1/src/cpu/x86/mtrr/mtrr.c
File src/cpu/x86/mtrr/mtrr.c:

https://review.coreboot.org/#/c/21915/1/src/cpu/x86/mtrr/mtrr.c@604
PS1, Line 604: 		b2_limit = MIN(ALIGN_UP(a2 + 1, 1 << fls(a1)) - 1, b2_limit);
This decision is flawed. There are (in theory) numbers where it
would still make sense to align higher up. Question is if it's
worth to fix (passing a1's alignment to optimize_var_mtrr_hole()
and counting every 0 above it twice). Or if we can make it ex-
plicit that a1 is zero? (I don't see other <4GiB use cases...)



-- 
To view, visit https://review.coreboot.org/21915
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefb064ce8c4f293490a19dd46054b966c63bde44
Gerrit-Change-Number: 21915
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 07 Oct 2017 15:24:55 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171007/5b97011c/attachment.html>