[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Remove UMA alignment optimization

Nico Huber (Code Review) gerrit at coreboot.org
Tue Oct 3 15:18:21 CEST 2017


Hello Arthur Heymans, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/21847

to look at the new patch set (#2).

Change subject: nb/intel/gm45: Remove UMA alignment optimization
......................................................................

nb/intel/gm45: Remove UMA alignment optimization

This code path was only triggered in one corner case: GFX UMA set to
48MiB. It created a hole below UMA to save MTRRs. But, this hole was
never accounted for when calculating cbmem_top(). Instead of trying
to fix it, remove it, it's not worth the trouble.

TEST=Booted lenovo/x200 with all available CMOS gfx_uma_size settings.

Change-Id: I3f4ceec4224d86113be9bfa3ce4759bed584640d
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M src/northbridge/intel/gm45/northbridge.c
M src/northbridge/intel/gm45/raminit.c
2 files changed, 3 insertions(+), 11 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/21847/2
-- 
To view, visit https://review.coreboot.org/21847
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f4ceec4224d86113be9bfa3ce4759bed584640d
Gerrit-Change-Number: 21847
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171003/98439bb1/attachment.html>


More information about the coreboot-gerrit mailing list