[coreboot-gerrit] Change in coreboot[master]: mb/dell/optiplex_790: add libgfxinit (NOT WORKING)

Christoph Pomaska (Code Review) gerrit at coreboot.org
Tue Oct 3 04:36:22 CEST 2017


Christoph Pomaska has uploaded this change for review. ( https://review.coreboot.org/21861


Change subject: mb/dell/optiplex_790: add libgfxinit (NOT WORKING)
......................................................................

mb/dell/optiplex_790: add libgfxinit (NOT WORKING)

Created a broken example for libgfxinit for Optiplex 790:
 - The init does not work yet and also breaks graphic init done by GRUB2/OS.
 - Screen remains black while init.
 - Device ends up only displaying a green screen when OS is booted

Change-Id: I58570c239492b2a15b1599ca6d03714bbd8dc387
Signed-off-by: Christoph Pomaska <cp_public at posteo.de>
---
M src/mainboard/dell/optiplex_790/Kconfig
M src/mainboard/dell/optiplex_790/Makefile.inc
A src/mainboard/dell/optiplex_790/gma-mainboard.ads
3 files changed, 31 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/21861/1

diff --git a/src/mainboard/dell/optiplex_790/Kconfig b/src/mainboard/dell/optiplex_790/Kconfig
index dd2c6f2..78f6148 100644
--- a/src/mainboard/dell/optiplex_790/Kconfig
+++ b/src/mainboard/dell/optiplex_790/Kconfig
@@ -7,10 +7,11 @@
 	select HAVE_ACPI_RESUME
 	select HAVE_ACPI_TABLES
 	select INTEL_INT15
-	select NORTHBRIDGE_INTEL_SANDYBRIDGE
+	select NORTHBRIDGE_INTEL_IVYBRIDGE # (Actually SANDYBRIDGE)
 	select SERIRQ_CONTINUOUS_MODE
 	select SOUTHBRIDGE_INTEL_BD82X6X
 	select USE_NATIVE_RAMINIT
+	select MAINBOARD_HAS_LIBGFXINIT
 
 config HAVE_IFD_BIN
 	bool
diff --git a/src/mainboard/dell/optiplex_790/Makefile.inc b/src/mainboard/dell/optiplex_790/Makefile.inc
index 6064cea..cd0b8a6 100644
--- a/src/mainboard/dell/optiplex_790/Makefile.inc
+++ b/src/mainboard/dell/optiplex_790/Makefile.inc
@@ -1,3 +1,4 @@
 romstage-y += early_southbridge.c
 romstage-y += gpio.c
 ramstage-y += gnvs.c
+ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads
diff --git a/src/mainboard/dell/optiplex_790/gma-mainboard.ads b/src/mainboard/dell/optiplex_790/gma-mainboard.ads
new file mode 100644
index 0000000..f1fa2dd
--- /dev/null
+++ b/src/mainboard/dell/optiplex_790/gma-mainboard.ads
@@ -0,0 +1,28 @@
+--
+-- Copyright (C) 2017 Bill XIE persmule at gmail.com
+--
+-- This program is free software; you can redistribute it and/or modify
+-- it under the terms of the GNU General Public License as published by
+-- the Free Software Foundation; either version 2 of the License, or
+-- (at your option) any later version.
+--
+-- This program is distributed in the hope that it will be useful,
+-- but WITHOUT ANY WARRANTY; without even the implied warranty of
+-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+-- GNU General Public License for more details.
+--
+
+with HW.GFX.GMA;
+with HW.GFX.GMA.Display_Probing;
+
+use HW.GFX.GMA;
+use HW.GFX.GMA.Display_Probing;
+
+private package GMA.Mainboard is
+
+   ports : constant Port_List :=
+     (DP1,
+      Analog,
+      others => Disabled);
+
+end GMA.Mainboard;

-- 
To view, visit https://review.coreboot.org/21861
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58570c239492b2a15b1599ca6d03714bbd8dc387
Gerrit-Change-Number: 21861
Gerrit-PatchSet: 1
Gerrit-Owner: Christoph Pomaska <cp_public at posteo.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171003/f50d9194/attachment.html>


More information about the coreboot-gerrit mailing list